-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow import of layout_test into 3rd party crates #3463
Conversation
Currently I can't import tests because `cfg(test)` isn't sent to sub-dependencies. This allows you to set a `yew/test` and import into your own tests.
Size Comparison
✅ None of the examples has changed their size significantly. |
Visit the preview URL for this PR (updated for commit 5634c02): https://yew-rs-api--pr3463-patch-1-rmiwbw8k.web.app (expires Fri, 20 Oct 2023 11:14:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! It can be merged once CI is green
Can we have an update on this? |
|
Description
This allows you to import layout_test into your crates as described in the docs. As you can't import things behind
#[cfg(test)]
.https://yew.rs/docs/more/testing
I think this was the intent of this PR
#2310
Should have no impact on the behavior of existing builds as you have to add
yew/test
to your build.Fixes #3329
Checklist