-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic type hints to boxed hooks #3633
Conversation
Visit the preview URL for this PR (updated for commit 75cdcc5): https://yew-rs-api--pr3633-add-hook-generics-grxmbo3f.web.app (expires Wed, 20 Mar 2024 19:07:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet and simple, thanks for the PR 👍
Description
When using complex type constructs in a boxed hook, the compiler can get confused and request a type hint on the call to the inner function.
This PR simply adds all generic types of the outer hook function as explicit types to the call of the inner function.
Checklist