Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Beacon fallback for stable version #137

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

AjayBenno
Copy link
Contributor

Support falling back to beacon for the current stable version. If the browser is detected to be firefox, send the event via beacon instead of fetch w/keepalive.

Also bumped version to v0.6.6.

Support falling back to beacon if fetch w/keepaliave is unsupported by
the browser.

TEST=manual,auto

Ran test-site locally and confirmed that beacon was used for firefox and
fetch w/keepalive was used in chrome. Confirmed all events still worked
as expected
@AjayBenno AjayBenno self-assigned this Feb 27, 2024
@AjayBenno AjayBenno changed the base branch from main to release/v0.6.5 February 27, 2024 02:27
@AjayBenno AjayBenno changed the base branch from release/v0.6.5 to release/v0.6.6 February 27, 2024 02:29
Copy link
Contributor

@ejaffee01 ejaffee01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/infra/ChatAnalyticsReporter.ts Show resolved Hide resolved
@AjayBenno AjayBenno merged commit 5146280 into release/v0.6.6 Feb 27, 2024
12 checks passed
@AjayBenno AjayBenno deleted the v0.6.6 branch February 27, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytics Beta (v.4): 422 Unprocessable Entity error for custom string Eneity ID
2 participants