use fetch instead of navigator.beacon #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates requests to use the fetch API with keepalive: true instead of navigator.beacon, so that in the future we can set custom HTTP headers. J=SLAP-1968 TEST=manual use the test-site to test that promise rejections are performed as expected
yen-tt
reviewed
Mar 21, 2022
yen-tt
reviewed
Mar 21, 2022
src/infra/HttpRequester.ts
Outdated
| xhr.setRequestHeader('Content-Type', 'text/plain;charset=UTF-8'); | ||
| xhr.send(data); | ||
| return true; | ||
| return fetch(url, { |
There was a problem hiding this comment.
fetch doesn't work for IE, do we plan on supporting that/need some sort of polyfill?
There was a problem hiding this comment.
I don't think we need to do any polyfilling here, answers-core also doesn't do any polyfilling in core but works fine in ie11. This is probably due to cross-fetch already using whatwg-fetch under the hood.
I added import 'core-js/stable' to the top of the test-site's index.ts and the site works fine in ie11.
There was a problem hiding this comment.
I updated HttpRequester to use window.fetch if available the same way core does it, and retested in ie11!
|
+1 |
yen-tt
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates requests to use the fetch API with keepalive: true
instead of navigator.beacon, so that in the future we can
set custom HTTP headers.
Updated
npm run devto use the esm build, since that's the one the test-site uses.J=SLAP-1968
TEST=manual
use the test-site to test that promise rejections are performed
as expected
test site runs in ie11 if
core-jsis added to the test-site's index.ts