Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update queryParam from id to ids to match pages pixel documentation #31

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

willgorick
Copy link
Contributor

updating the id query param to ids to match the documentation here and to fix entity_id not associating properly with events bug

@benmcginnis
Copy link
Member

this fixes: #32

@benmcginnis benmcginnis self-requested a review September 28, 2022 14:00
Copy link
Member

@benmcginnis benmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benmcginnis benmcginnis merged commit 1bf1bc0 into main Sep 28, 2022
@benmcginnis benmcginnis deleted the wgorick/idfix branch September 28, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants