Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove www from yextevents URLs #47

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Remove www from yextevents URLs #47

merged 2 commits into from
Aug 10, 2023

Conversation

ejaffee01
Copy link
Contributor

@ejaffee01 ejaffee01 commented Aug 7, 2023

Pixels: Remove www prefix from yextevents URLs

Remove www from yextevent urls and tests.

J=FUS-5824
R=abenno, mtian
TEST=auto

The automatic checks in the github repo pass.
In addition, ran test-site in the analytics repo and fired off events.
All URL's with the yextevents domain did not have a www prefix.

@ejaffee01 ejaffee01 marked this pull request as ready for review August 7, 2023 15:57
@ejaffee01 ejaffee01 self-assigned this Aug 7, 2023
@ejaffee01 ejaffee01 requested a review from mtian725 August 7, 2023 16:09
Copy link
Contributor

@AjayBenno AjayBenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a commit message that follows the commit message guidelines?

https://wiki.yext.to/index.php/Commit_messages

Remove www from yextevent urls and tests.

J=FUS-5824
R=abenno, mtian
TEST=auto

The automatic checks in the github repo pass.
In addition, ran test-site in the analytics repo and fired off events.
All URL's with the yextevents domain did not have a www. prefix.
@ejaffee01 ejaffee01 merged commit 768b4ca into main Aug 10, 2023
13 checks passed
@ejaffee01 ejaffee01 deleted the removeWWW branch August 10, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants