Skip to content

Commit

Permalink
Resolved deprecation warnings from inlineAssetHtmlPlugin and webpack (#…
Browse files Browse the repository at this point in the history
…796)

Updated html-webpack-plugin, used by inlineAssetHtlmPlugin, to be more integrated with webpack v5, which got rid of the deprecated warnings from older v4 with asset and public path.
Since inlineAssetHTMLPlugin only access compilation.assets without modification, no changes are needed in the js file. Instead, updated webpack version to remove compilation asset warning.

J=SLAP-1307
TEST=compile

Co-authored-by: Yen Truong <ytruong@yext.com>
  • Loading branch information
yen-tt and Yen Truong authored May 27, 2021
1 parent 25d08e9 commit 32455b8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions static/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"grunt-contrib-watch": "^1.1.0",
"grunt-webpack": "^4.0.0",
"html-loader": "^1.1.0",
"html-webpack-plugin": "^4.3.0",
"html-webpack-plugin": "^5.3.1",
"jambo": "^1.11.0",
"jsdom": "^16.4.0",
"mini-css-extract-plugin": "^1.6.0",
Expand All @@ -39,7 +39,7 @@
"sass": "^1.34.0",
"sass-loader": "^8.0.2",
"simple-git": "^2.15.0",
"webpack": "^5.4.0",
"webpack": "^5.37.1",
"webpack-cli": "^4.2.0",
"webpack-merge": "^5.7.3"
},
Expand Down

0 comments on commit 32455b8

Please sign in to comment.