Correct bug in isStaging method.
#1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR corrects a bug in the `isStaging` method. If you were referred to a Production site from a Staging link, `isStaging` would incorrectly report `true`. This is because the `includes` check on the `href` would catch the Staging `referrerPageUrl`. Simply comparring `window.location.hostname` instead of `window.location.href` fixes this. I also did some code cleanup in this method and its test suite. J=SLAP-2546 TEST=auto
oshi97
reviewed
Jan 9, 2023
oshi97
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects a bug in the
isStagingmethod. If you were referred to a Production site from a Staging link,isStagingwould incorrectly reporttrue. This is because theincludescheck on thehrefwould catch the StagingreferrerPageUrl. Simply comparringwindow.location.hostnameinstead ofwindow.location.hreffixes this. I also did some code cleanup in this method and its test suite.J=SLAP-2546
TEST=auto