Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run on-document-load js partial through babel helper #789

Merged
merged 1 commit into from
May 24, 2021

Conversation

oshi97
Copy link
Contributor

@oshi97 oshi97 commented May 21, 2021

The exit disclaimer code instructions tell people to put
their code in the on-document-load partial. We want this
partial to work in ie11 even if people use newer features.

J=SLAP-1131
TEST=manual

see that I can specify an arrow func in on-doc-load and it
gets transpiled

The exit disclaimer code instructions tell people to put
their code in the on-document-load partial. We want this
partial to work in ie11 even if people use newer features.

J=SLAP-1131
TEST=manual

see that I can specify an arrow func in on-doc-load and it
gets transpiled
@oshi97 oshi97 changed the title run on-document-load js partial through #babel helper run on-document-load js partial through babel helper May 21, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 5.416% when pulling 68b0e80 on dev/babel-on-doc-load into d9a59a4 on develop.

@oshi97 oshi97 merged commit dab722e into develop May 24, 2021
@oshi97 oshi97 deleted the dev/babel-on-doc-load branch May 24, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants