Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the snapshots #810

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented Jun 3, 2021

Reorganize snapshots to make them simpler

Rather than a homepage snaphshot, we can just use univeral search instead and take separate snapshots for no results. Also switch to the non-multilang financial-professional-location because we want full test coverage on the non-multilang cards.

J=SLAP-1361
TEST=visual

Check the updated percy snapshots

@coveralls
Copy link

coveralls commented Jun 3, 2021

Coverage Status

Coverage remained the same at 5.532% when pulling 266b64a on dev/snapshot-reordering into b77e9f2 on feature/card-visual-tests.

@cea2aj cea2aj merged commit 8693f6e into feature/card-visual-tests Jun 4, 2021
@cea2aj cea2aj deleted the dev/snapshot-reordering branch June 4, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants