return correct formatted time for given locale #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the defined field `this._locale` instead of `this.locale`. This will cause some changes in percy snapshots launched test site and see that es pages use h24 format and en use h12 format
|
I would let Product know about this issue. They may even want it in as a hotfix |
tmeyer2115
approved these changes
Aug 27, 2021
|
To @cea2aj 's point, we may want this in a Theme v1.23.1 hotfix. We may also want a HH Post so people can patch their older versions. I will get with Product on that. But, we should be good to merge into develop for now. |
tmeyer2115
pushed a commit
that referenced
this pull request
Aug 30, 2021
use the defined field `this._locale` instead of `this.locale`. This will cause some changes in percy snapshots launched test site and see that es pages use h24 format and en use h12 format Co-authored-by: Yen Truong <ytruong@yext.com>
Merged
tmeyer2115
added a commit
that referenced
this pull request
Aug 30, 2021
Merged
tmeyer2115
added a commit
that referenced
this pull request
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the defined field
this._localeinstead ofthis.locale. This will cause some changes in percy snapshotstest=manual
launched test site and see that es pages use h24 format and en use h12 format