Add feedback buttons to cards #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can ignore the failing Translation Test for now. The Theme should not be running that test on every PR. Fixing this check will be done as part of another item. |
cea2aj
reviewed
Aug 31, 2021
cea2aj
reviewed
Aug 31, 2021
|
Based on the Percy snapshots, I think some of the feedback buttons need to be adjusted so that they are on the bottom right of the cards. We may also need to add some more padding and make the buttons a little smaller |
cea2aj
reviewed
Aug 31, 2021
cea2aj
reviewed
Aug 31, 2021
tmeyer2115
reviewed
Sep 1, 2021
tmeyer2115
reviewed
Sep 1, 2021
tmeyer2115
approved these changes
Sep 1, 2021
nmanu1
added a commit
that referenced
this pull request
Oct 12, 2021
Add generic thumbs up/down feedback buttons and analytics to all cards (#938, #939, #940). - Include a `feedback` config option in `dataForRender` so user can specify if feedback buttons should appear on the card or not. - Create a shared partial for the buttons that is used in all cards, including direct answer cards - Update analytics for direct answer feedback with additional event attributes. J=SLAP-1544, 1545 TEST=manual Smoke testing to see if thumbs up/down buttons function as expected on all cards and send analytics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add thumbs up/down feedback buttons to all cards without doing card-specific styling yet. Created a shared partial for the buttons, as well as a new config option in 'dataForRender', called 'feedback' that controls whether or not the buttons appear. Used the shared partial in all cards, including direct answers cards.
J=SLAP-1544
TEST=manual
Smoke testing to see if thumbs up/down buttons appear on each card