v1.11.1 #1779
Merged
v1.11.1 #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See this piece of documentation: https://developers.google.com/maps/documentation/javascript/browsersupport. Version 3.47 of the Maps Javascript API will be the last version to support IE11. TEST=manual Saw v3.47 of the API being used. Saw Google Maps appear on Universal as expected.
Fix the failing useragent acceptance tests The useragent acceptance tests have been failing due to the error: `undefined is not an object (evaluating 'za.objectHasOwnProperty.call(s,"writable")')`, and the callstack shows that testcafe code, not our code, is causing the issue. The error message suggests enabling "skipJsErrors` so that the test doesn't fail. The error is only thrown when ran through testcafe, which further suggests that the issue is on testcafe's side. Therefore, by setting this option we can get the test passing again. This means that JS errors on the page won't cause the test to fail, however I think that's okay for this test since we have other acceptance tests which would fail if there were JS errors on the page. J=none TEST=none Confirm that the tests now pass.
Throw error from not having `ytag` script tag for conversion tracking opt in would prevent a search fired on load. This is an aggressive behavior as analytics shouldn't affect search behavior. This pr updated the two throw error into console error instead. Same as #1771 but without acceptance tests changes TEST=manual Added `ANSWERS.setConversionsOptIn(true);` to a local index page with Answers setup. see that the previously uncaught throw error is now a console error and a search on load is no longer blocked. <img width="1786" alt="Screen Shot 2022-08-31 at 8 36 25 AM" src="https://user-images.githubusercontent.com/36055303/187679764-b5c9a6e6-bf12-4467-a42b-66fb3052846d.png">
oshi97
previously approved these changes
Sep 2, 2022
yen-tt
commented
Sep 2, 2022
| @@ -11,7 +11,8 @@ if [[ $GITHUB_REF_NAME == release/* | |||
| || $GITHUB_REF_NAME == master | |||
| || $GITHUB_REF_NAME == support/* ]] | |||
| then | |||
| npx testcafe "browserstack:ie@11.0,browserstack:safari" --config-file ./.github/testcafe.json -q | |||
| # npx testcafe "browserstack:ie@11.0,browserstack:safari" --config-file ./.github/testcafe.json -q | |||
| npx testcafe "browserstack:ie@11.0" --config-file ./.github/testcafe.json -q | |||
There was a problem hiding this comment.
The issue with browserstack acceptance test hanging on page load for “Universal search page works as expected” is coming from safari specifically. I tried manually loading up the universal page for that test on safari locally and run through a couple steps, which seems to work fine. Talked to tom, he's okay with ignoring it for now. I removed it from this script so so the deploy actions would pass properly, will add it back after the release.
nmanu1
approved these changes
Sep 2, 2022
oshi97
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes