Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Browserstack acceptance testing on IE11 #1791

Merged
merged 7 commits into from
Nov 29, 2022
Merged

Remove Browserstack acceptance testing on IE11 #1791

merged 7 commits into from
Nov 29, 2022

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Nov 29, 2022 •
edited

Now that the Google Maps JS API has dropped support for IE11, Browserstack acceptance tests on IE11 fail. This PR updates the Browserstack acceptance test script to only run on Safari, and not IE11 anymore.

J=SLAP-2502
TEST=auto

See that the Browserstack check on this PR only runs on Safari and there are no more Google Maps API errors.

@coveralls
Copy link

coveralls commented Nov 29, 2022 •
edited

Coverage Status

Coverage remained the same at 61.534% when pulling ad37777 on dev/remove-browserstack-ie11 into 8172b61 on hotfix/v1.15.1.

oshi97
oshi97 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@oshi97 oshi97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@nmanu1 nmanu1 requested a review from oshi97 November 29, 2022 21:59
@nmanu1 nmanu1 requested review from oshi97 and a team November 29, 2022 22:00
@nmanu1 nmanu1 merged commit b138213 into hotfix/v1.15.1 Nov 29, 2022
@nmanu1 nmanu1 deleted the dev/remove-browserstack-ie11 branch November 29, 2022 22:01
@nmanu1 nmanu1 mentioned this pull request Nov 29, 2022
Merged
nmanu1 added a commit that referenced this pull request Dec 1, 2022
@nmanu1
v1.15.1 (#1792)
530f4bd 
### Changes
- Update GitHub workflows to address deprecation warnings (#1789)
- Stop testing on IE11 now that the Google Maps JS API has dropped support for IE11 (#1791, #1793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshi97 oshi97 Awaiting requested review from oshi97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nmanu1 @coveralls @oshi97