Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IE11NoCacheHook #1793

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Remove IE11NoCacheHook #1793

merged 1 commit into from
Dec 1, 2022

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Dec 1, 2022 •
edited

Now that we've removed acceptance testing on IE11, the IE11NoCacheHook is no longer needed. This PR removes it and its uses.

J=SLAP-2502
TEST=none

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.534% when pulling d75a041 on dev/remove-IE11NoCacheHook into b138213 on hotfix/v1.15.1.

@nmanu1 nmanu1 merged commit 4567c4f into hotfix/v1.15.1 Dec 1, 2022
@nmanu1 nmanu1 deleted the dev/remove-IE11NoCacheHook branch December 1, 2022 19:04
@nmanu1 nmanu1 mentioned this pull request Dec 1, 2022
Merged
nmanu1 added a commit that referenced this pull request Dec 1, 2022
@nmanu1
v1.15.1 (#1792)
530f4bd 
### Changes
- Update GitHub workflows to address deprecation warnings (#1789)
- Stop testing on IE11 now that the Google Maps JS API has dropped support for IE11 (#1791, #1793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshi97 oshi97 oshi97 approved these changes

@yen-tt yen-tt yen-tt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nmanu1 @coveralls @oshi97 @yen-tt