Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GH workflows to remove deprecation warnings #1789

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Update GH workflows to remove deprecation warnings #1789

merged 1 commit into from
Nov 28, 2022

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Nov 18, 2022 •
edited
Loading

Upgrade GitHub actions (actions/checkout, actions/setup-node, actions/upload-artifact, actions/download-artifact, and aws-actions/configure-aws-credentials) and update set-output calls to remove all deprecation warnings from the workflows. These warnings were for the deprecation of Node 12 and for the set-output and save-state commands.

J=SLAP-2427
TEST=manual

Test in this PR as well as on dev/test-output-changes. See that the warnings are no longer present (except for the exception mentioned in this PR).

Note: The Browserstack acceptance test is failing because the Google Maps JS API dropped support for IE11 recently (see Oliver's post on Slack).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.534% when pulling 3a8665a on dev/set-output into 522b117 on develop.

@nmanu1 nmanu1 requested a review from a team November 18, 2022 22:41
@nmanu1 nmanu1 requested a review from yen-tt November 28, 2022 14:28
@nmanu1 nmanu1 merged commit 8172b61 into develop Nov 28, 2022
@nmanu1 nmanu1 deleted the dev/set-output branch November 28, 2022 15:48
@nmanu1 nmanu1 mentioned this pull request Nov 29, 2022
Merged
nmanu1 added a commit that referenced this pull request Dec 1, 2022
@nmanu1
v1.15.1 (#1792)
530f4bd 
### Changes
- Update GitHub workflows to address deprecation warnings (#1789)
- Stop testing on IE11 now that the Google Maps JS API has dropped support for IE11 (#1791, #1793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatimblin tatimblin tatimblin approved these changes

@yen-tt yen-tt yen-tt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nmanu1 @coveralls @tatimblin @yen-tt