Version 1.15.3 #1804
Merged
Version 1.15.3 #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, when a Navigation component's parentUrl is set, clicking on the link will still open the original url with target="_self" instead of target="_parent". This ensures that when a link is clicked on from within an iframe, the link will only cause the iframe to refresh, and not the parent frame. J=SLAP-2638 TEST=manual hook up my local SDK to a local copy of the ufc answers experience See that clicking navigation links works without triggering full page reloads see that a new tab is still opened when I cmd + click see that middle click still opens a new tab
nmanu1
reviewed
Feb 22, 2023
nmanu1
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes