Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Actions to sync a separate EU build #1819

Merged
merged 2 commits into from
May 4, 2023

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented May 3, 2023

Previously the GH actions were syncing the US
assets to GCP. This change updates the actions so
that a seprate EU build is ran, and only those assets are synced to GCP. Also, remove the syncing of assets from dev branches.

J=BACK-2268
TEST=none

I will test this with a test version (e.g. 0.0.10) and confirm the build works as expected

Previously the GH actions were syncing the US
assets to GCP. This change updates the actions so
that a seprate EU build is ran, and only those assets
are synced to GCP. Also, remove the syncing of assets
from dev branches.

J=BACK-2268
TEST=none

I will test this with a test version (e.g. 0.0.10)
and confirm the build works as excpected
@coveralls
Copy link

coveralls commented May 3, 2023

Coverage Status

Coverage: 61.4% (-0.04%) from 61.441% when pulling 705f40f on dev/eu-gh-workflow-updates into 96cc51e on develop.

Copy link
Contributor

@EmilyZhang777 EmilyZhang777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But would like to have mcgin take a look

Copy link
Member

@benmcginnis benmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we don't need to do anything for lower environments?

@cea2aj
Copy link
Member Author

cea2aj commented May 4, 2023

I assume we don't need to do anything for lower environments?

yes, I confirmed with Tom that we only need to host assets in the EU for our full releases, and not for dev builds

@cea2aj cea2aj merged commit fa0e712 into develop May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants