Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.16.1 #1826

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Version 1.16.1 #1826

merged 3 commits into from
Jun 29, 2023

Conversation

benmcginnis
Copy link
Member

@benmcginnis benmcginnis commented May 17, 2023

Version 1.16.1

Features

Assets hosted in the EU will now properly send analytics events to the EU hosted analytics domain (#1827)

EmilyZhang777
EmilyZhang777 previously approved these changes May 17, 2023
@coveralls
Copy link

coveralls commented May 17, 2023

Coverage Status

coverage: 61.393% (-0.001%) from 61.394% when pulling 9643b81 on hotfix/v1.16.1 into ad4a9ba on master.

When the cloud region is EU, send analytics events to https://www.eu.yextevents.com

J=BACK-2362
TEST=manual

Build EU and US versions locally. Connected them to a test jambo site and confirmed the EU and US events fire properly. Checked the user_events table in the EU and confirmed the events are there.
@cea2aj cea2aj changed the title fix: implementation of accesssible text for vertical result counts Hotfix v1.16.1 Jun 28, 2023
@cea2aj cea2aj changed the title Hotfix v1.16.1 Version 1.16.1 Jun 28, 2023
github-actions bot and others added 2 commits June 28, 2023 14:50
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ounts (#1830)

The current implementation of verticalresultcount.hbs unnecessarily uses an aria-label and aria-hidden property to handle text that is already accessible for a non-interactive element.

J=TECHOPS-9030

Co-authored-by: Ben McGinnis <bmcginnis@yext.com>
@cea2aj cea2aj merged commit 21bf511 into master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants