This repository has been archived by the owner on May 8, 2023. It is now read-only.
docker: Notice when container is no longer running #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aside from calling edward status, the Status function is called frequently by the runner. We utilize that to close the done channel which is normally done by Stop. Probably the less hacky way to implement this is to see how commandline deals with this scenario. (I think it might use logic in status.go getState) See for more info: https://yext.slack.com/archives/CDW79LMCJ/p1541712100011800
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from calling edward status, the Status function is called
frequently by the runner. We utilize that frequent call to close the done channel
which is normally done by Stop.
Probably the less hacky way to implement this is to see how commandline
deals with this scenario. (I think it might use logic in status.go getState)
See for more info: https://yext.slack.com/archives/CDW79LMCJ/p1541712100011800