feat(plugin): generate functionMetadata.json #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeyer2115
reviewed
Feb 28, 2023
packages/pages/src/vite-plugin/build/closeBundle/functionMetadata.ts
Outdated
Show resolved
Hide resolved
packages/pages/src/vite-plugin/build/closeBundle/functionMetadata.ts
Outdated
Show resolved
Hide resolved
tmeyer2115
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a step to the vite-plugin's
buildcommand (i.e.pages build) to generatefunctionMetadata.json. This file contains a mapping of the files in thefunctionsdirectory to the names of the functions that are their default exports. If there is no top-levelfunctionsdirectory,functionMetadata.jsonis not generated.J=SLAP-2625
TEST=manual
Point the locations starter to a local pack of PagesJS and see that the file is correctly generated when there is a
functionsdirectory, and is not generated if there is nofunctionsdirectory.