-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matchedSubstrings to spellCheck interface #192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2739777204
💛 - Coveralls |
oshi97
approved these changes
Jul 25, 2022
oshi97
suggested changes
Jul 25, 2022
yen-tt
reviewed
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to confirm, you want to publish a beta version right? This should point to develop instead of master
yen-tt
reviewed
Jul 25, 2022
yen-tt
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raiden needs access to
matchedSubstrings
from the spellCheck part of the Search API response. Since changingcorrectedQuery
from a string to an object would be a breaking change, we added a new property to the spellCheck interface that holds thematchedSubstrings
.matchedSubstrings
was also added to the Core response when the spellCheck object is created increateSpellCheck
.J=SLAP-2274
TEST=manual
It was verified that when spellCheck was provided in the Core response, that
matchedSubstrings
was also provided as its own property.