fix compilation_check_for_test_site #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a github workflow the `cd` command only affects the current step J=NONE TEST=auto
Pull Request Test Coverage Report for Build 2869251223
💛 - Coveralls |
nmanu1
reviewed
Aug 16, 2022
.github/workflows/run-tests.yml
Outdated
| - run: cd test-site | ||
| - run: npm i | ||
| - run: npm run build | ||
| - run: cd test-site && npm i && npm run build |
There was a problem hiding this comment.
could this job use the reusable run-tests workflow and pass this last step in as the test script?
This reverts commit f9d8071.
nmanu1
reviewed
Aug 16, 2022
nmanu1
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a github workflow the
cdcommand only affects the current step. This was causing false positives.Also fix a casing issue with a test-site import on the js side.
J=NONE
TEST=manual
checked out a branch that should be failing, saw it fail locally, but succeed in the PR it's in
in the github workflow logs for the PR it's in, I see the regular search-core build being run twice,
and the test-site build not being run