Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Reference to provideCore in Doc #235

Merged
merged 2 commits into from
May 4, 2023

Conversation

EmilyZhang777
Copy link
Contributor

This PR removes the reference to provideCore in the doc since it is not re-exported in headless and was causing an issue.
It also bumps the beta version to 2.3.0-beta.1.

J=BACK-2270
TEST=auto

Ran tests under tests/.

This PR removes the reference to provideCore in the doc since it is not re-exported in headless and was causing an issue.
It also bumps the beta version to 2.3.0-beta.1.

J=BACK-2270
TEST=auto

Ran tests under tests/.

Change-Id: I906f8c1f5afd9ae18461e44dd222e6e4169c9e31
@EmilyZhang777 EmilyZhang777 requested a review from a team as a code owner May 4, 2023 22:11
@coveralls
Copy link

coveralls commented May 4, 2023

Pull Request Test Coverage Report for Build 4887804390

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 90.61%

Totals Coverage Status
Change from base Build 4512684737: 0.2%
Covered Lines: 217
Relevant Lines: 234

💛 - Coveralls

@cea2aj
Copy link
Member

cea2aj commented May 4, 2023

remember to target develop

@EmilyZhang777 EmilyZhang777 changed the base branch from master to develop May 4, 2023 22:17
@EmilyZhang777 EmilyZhang777 merged commit a3c4e19 into develop May 4, 2023
@EmilyZhang777 EmilyZhang777 deleted the dev/remove-provide-core-in-doc branch May 8, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants