RichTextV2 and Markdown changes #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Textv2 and markdown in snippets J=BACK-2241 TEST=manual Tested using a modified version of the test site in the search-core repository. Also verified that the value field in direct answer snippet contained converted HTML for queries.
Pull Request Test Coverage Report for Build 5283428919
💛 - Coveralls |
benmcginnis
reviewed
Jun 14, 2023
src/models/searchservice/response/directanswer/FeaturedSnippetDirectAnswer.ts
Show resolved
Hide resolved
Point MarkdownSnippetDirectAnswer to the correct FieldType
cea2aj
reviewed
Jun 15, 2023
Comment on lines
28
to
32
| if (fieldType != BuiltInFieldType.MultiLineText && | ||
| fieldType != BuiltInFieldType.RichText && | ||
| fieldType != BuiltInFieldType.RichText_v2 && | ||
| fieldType != BuiltInFieldType.Html && | ||
| fieldType != BuiltInFieldType.Markdown) { |
There was a problem hiding this comment.
nit: can you put these built in field types in a list and call the includes method instead of checking each one individually?
create list of supported fieldTypes to check with
fix linting issues
benmcginnis
reviewed
Jun 15, 2023
benmcginnis
reviewed
Jun 15, 2023
benmcginnis
approved these changes
Jun 15, 2023
benmcginnis
added a commit
that referenced
this pull request
Jun 28, 2023
Support new Rich Text & Markdown Field Types (#241) - We added support for the new Rich Text & Markdown returned as raw html in direct answers.
Merged
benmcginnis
added a commit
that referenced
this pull request
Jun 28, 2023
Support new Rich Text & Markdown Field Types (#241) - We added support for the new Rich Text & Markdown returned as raw html in direct answers.
cea2aj
added a commit
that referenced
this pull request
Jun 28, 2023
# Version 2.4.0 ### Features Support new Rich Text & Markdown Field Types (#241) - We added support for the new Rich Text & Markdown returned as raw html in direct answers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for direct answers to return raw HTML of converted RichTextv2 and markdown in snippets
J=BACK-2241
TEST=manual
Tested using a modified version of the test site in the search-core repository. Also verified that the value field in direct answer snippet contained converted HTML for queries.