Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2.5.0 #162

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Version 2.5.0 #162

merged 4 commits into from
Dec 8, 2023

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Dec 8, 2023 •
edited
Loading

Changes

Fixes

benmcginnis and others added 4 commits July 12, 2023 13:48
@benmcginnis
Merge pull request #155 from yext/dev/merge-v2.4.0-4e7a2c2-into-develop
d562dc8 
Merge main (v2.4.0) into develop
@cea2aj
Document vertical support (#156)
8e4777e 
Add document vertical support

See yext/search-core#249 for more info

J=BACK-2523
TEST=manual

Ran the test site locally, connected it to an experience with a document vertical, and confirmed that the segment appeared in the results
@nmanu1
Upgrade @babel/traverse (#159)
0e4ccbb 
Upgrade `@babel/traverse` from v7.18.5 to 7.23.5 to address a critical vulnerability in the package.

J=none
TEST=auto
@nmanu1
Prepare v2.5.0 (#161)
0dc7816 
Bump package.json to v2.5.0 and search-core to v2.5.0.

J=none
TEST=auto
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7141720386

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.972%
Totals Coverage Status
Change from base Build 5534316688: 0.0%
Covered Lines: 338
Relevant Lines: 357
💛 - Coveralls

@nmanu1 nmanu1 marked this pull request as ready for review December 8, 2023 13:08
@nmanu1 nmanu1 requested a review from a team as a code owner December 8, 2023 13:08
benmcginnis
benmcginnis approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@benmcginnis benmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanu1 nmanu1 merged commit 93a8083 into main Dec 8, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmcginnis benmcginnis benmcginnis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nmanu1 @coveralls @benmcginnis @cea2aj