Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump search-core to v2.5.51 #167

Closed
wants to merge 7 commits into from
Closed

Conversation

EmilyZhang777
Copy link
Contributor

No description provided.

@EmilyZhang777 EmilyZhang777 requested a review from a team as a code owner January 30, 2024 21:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7717504828

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.972%

Totals Coverage Status
Change from base Build 7717434347: 0.0%
Covered Lines: 338
Relevant Lines: 357

💛 - Coveralls

Copy link
Contributor

@nmanu1 nmanu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to make a hotfix for search-headless? none of the vulnerabilities fixed in search-core affect what's actually exported by the package. they were all in the test-site or for devDependencies. also, new users of search-headless would automatically get the latest patch of search-core without this update since we don't pin to a specific patch

@EmilyZhang777
Copy link
Contributor Author

That's fair. I'll abandon this PR then.

@EmilyZhang777 EmilyZhang777 deleted the dev/bump-search-core branch January 31, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants