Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(feat): add explicit arguments #52

Merged
merged 2 commits into from
Apr 15, 2022
Merged

chore(feat): add explicit arguments #52

merged 2 commits into from
Apr 15, 2022

Conversation

yezz123
Copy link
Owner

@yezz123 yezz123 commented Apr 15, 2022

No description provided.

@yezz123 yezz123 added the enhancement New feature or request label Apr 15, 2022
@yezz123 yezz123 self-assigned this Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #52 (b279d9a) into main (5e4a5ce) will decrease coverage by 2.32%.
The diff coverage is 86.66%.

@@             Coverage Diff             @@
##              main      #52      +/-   ##
===========================================
- Coverage   100.00%   97.67%   -2.33%     
===========================================
  Files            4        4              
  Lines           85       86       +1     
  Branches         8        7       -1     
===========================================
- Hits            85       84       -1     
- Misses           0        2       +2     
Impacted Files Coverage Δ
fastapi_class/routable.py 100.00% <ø> (ø)
fastapi_class/decorators.py 90.90% <86.66%> (-9.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4a5ce...b279d9a. Read the comment docs.

@sourcery-ai
Copy link

sourcery-ai bot commented Apr 15, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 12.16%.

Quality metrics Before After Change
Complexity 0.78 ⭐ 0.26 ⭐ -0.52 👍
Method Length 25.86 ⭐ 61.36 🙂 35.50 👎
Working memory 7.02 🙂 13.84 😞 6.82 👎
Quality 86.19% 74.03% 🙂 -12.16% 👎
Other metrics Before After Change
Lines 142 330 188
Changed files Quality Before Quality After Quality Change
setup.py 63.45% 🙂 63.60% 🙂 0.15% 👍
fastapi_class/decorators.py 93.78% ⭐ 71.92% 🙂 -21.86% 👎
fastapi_class/routable.py 79.17% ⭐ 81.79% ⭐ 2.62% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
fastapi_class/decorators.py get 0 ⭐ 100 🙂 28 ⛔ 53.80% 🙂 Extract out complex expressions
fastapi_class/decorators.py post 0 ⭐ 100 🙂 28 ⛔ 53.80% 🙂 Extract out complex expressions
fastapi_class/decorators.py put 0 ⭐ 100 🙂 28 ⛔ 53.80% 🙂 Extract out complex expressions
fastapi_class/decorators.py delete 0 ⭐ 100 🙂 28 ⛔ 53.80% 🙂 Extract out complex expressions
fastapi_class/routable.py RoutableMeta.__new__ 1 ⭐ 42 ⭐ 11 😞 74.88% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@yezz123 yezz123 merged commit fd826f9 into main Apr 15, 2022
@yezz123 yezz123 deleted the feat/args branch April 15, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant