Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modifyMVar and modifyMVar_ exceptional behavior looks off #4

Open
treeowl opened this issue Jan 15, 2019 · 0 comments · May be fixed by #9
Open

modifyMVar and modifyMVar_ exceptional behavior looks off #4

treeowl opened this issue Jan 15, 2019 · 0 comments · May be fixed by #9

Comments

@treeowl
Copy link
Contributor

treeowl commented Jan 15, 2019

In case of an exception, modifyMVar and modifyMVar_ use the strict putMVar to try to restore the MVar contents. This can itself throw an exception or fail to terminate, preventing the contents from being restored. I'm quite confident they should use the version from Control.Concurrent.MVar in the exception handler.
treeowl added a commit to treeowl/strict-concurrency that referenced this issue Jan 15, 2019
@treeowl
Fix a bunch of bugs and infelicities
b08ea4b 
Fixes ygale#2, ygale#3, ygale#4, ygale#5, ygale#6, and ygale#8
@treeowl treeowl linked a pull request Jan 15, 2019 that will close this issue
Open
treeowl added a commit to treeowl/strict-concurrency that referenced this issue Jan 15, 2019
@treeowl
Fix a bunch of bugs and infelicities
63b06d6 
Fixes ygale#2, ygale#3, ygale#4, ygale#5, ygale#6, and ygale#8
treeowl added a commit to treeowl/strict-concurrency that referenced this issue Jan 15, 2019
@treeowl
Fix a bunch of bugs and infelicities
80b6e54 
Fixes ygale#2, ygale#3, ygale#4, ygale#5, ygale#6, and ygale#8
treeowl added a commit to treeowl/strict-concurrency that referenced this issue Jan 15, 2019
@treeowl
Fix a bunch of bugs and infelicities
a449ac4 
Fixes ygale#2, ygale#3, ygale#4, ygale#5, ygale#6, and ygale#8
treeowl added a commit to treeowl/strict-concurrency that referenced this issue Jan 15, 2019
@treeowl
Fix a bunch of bugs and infelicities
6b7fbaf 
Fixes ygale#2, ygale#3, ygale#4, ygale#5, ygale#6, and ygale#8
treeowl added a commit to treeowl/strict-concurrency that referenced this issue Jan 15, 2019
@treeowl
Fix a bunch of bugs and infelicities
5d6cd97 
Fixes ygale#2, ygale#3, ygale#4, ygale#5, ygale#6, and ygale#8
treeowl added a commit to treeowl/strict-concurrency that referenced this issue Jan 16, 2019
@treeowl
Fix a bunch of bugs and infelicities
64deaaa 
Fixes ygale#2, ygale#3, ygale#4, ygale#5, ygale#6, and ygale#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a bunch of bugs and infelicities treeowl/strict-concurrency
1 participant
@treeowl