Fixes #7: Add controlfile (control file) directive to be able to add custom control file in the config.tar.gz section #8
Conversation
|
Hi @ygoe could you also help to review this PR as well? Thanks. |
There was a problem hiding this comment.
Interesting idea. I also wanted to look at these template files and debconf and everything but didn't get to it yet. Your flexible approach lets the user add any files to the control file. Is that actually necessary or would it be enough to add the two mentioned files only?
|
Oh, if the flexible approach will be used, I'd suggest renaming the directive from |
Actually the file could be any name, that is why I need such flexibility, user could give the file name anything as long as it postfixes with |
Agreed with |
ichan-akira
changed the title
…already existing DebFileItem class. - Adjust regex for controlfile to allow input for SourcePath, IsText, Mode, UserId, and GroupId. - Simplify existing implementation of initializing DebFileItem objects. - Make all properties initialization for DebFileItem more explicit (explicitly initialized) to make code easier to understand. - DebPackage.WritePackage() method now execute AddFile() for control file item with user defined UserId, GroupId, and Mode. - Adjust DebPackage.ResolveFileItems() to allow processing for null DestPath. - Convert pubic fields in DebControlParams and DebFileItem to become property with getter setter (following OOP principle: encapsulation).
|
I have fixed the PR, could you help to review again @ygoe, thanks 🙇 |
Feature:
controlfile(control file) directive to be able to add custom control file in theconfig.tar.gzsection.SourcePath,IsText,Mode,UserId, andGroupId.DebPackage.ResolveFileItems()to allow processing fornullinDestPath.Clean up:
DebFileItemobjects.DebFileItemmore explicit (explicitly initialized) to make code easier to understand.DebControlParamsandDebFileItemto become property with getter setter (following OOP principle: encapsulation).Fixes #7