Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented resolving AssemblyMetadata, build configuration format strings and build error on dirty repo #14

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

0x6d61726b
Copy link
Contributor

Hello Yves,

I have extended Net Revision Task with the following changes:

  • Implemented resolving of AssemblyMetadata attributes value format strings (enabled by default)
  • BuildTime is updated if GetVersion() is called (otherwise the build time stays constant until the Solution is reloaded)
  • Added {bconf}, {BCONF} and {bconf:<sep>:<ref>} format strings to resolve build configuration names
  • Implemented a RegEx match pattern to trigger a build error if the repository contains modifications

Please let me know if you don't agree with the changes or see potential for optimizations.

Best regards,
Mark

@0x6d61726b
Copy link
Contributor Author

Hello Ives,

I added another patch to avoid the error message "Revision ID cannot be truncated to dotted-numeric" when the repository was empty and did not yet receive a tag. I can't tell if the solution I have chosen with 56485af is the way to go, but it works for the issue I currently had.

Best regards,
Mark

@ygoe
Copy link
Owner

ygoe commented Nov 18, 2020

Just wanted to give a quick feedback. I'm very busy with other time-critical projects at the moment but these changes sound interesting and I'll take a look at them. Please don't be too sad if I won't make it anymore this year.

@0x6d61726b
Copy link
Contributor Author

Thanks for your feedback, Yves. I made a local build and can work with it for now. Take your time.

@0x6d61726b
Copy link
Contributor Author

Merged latest changes and fixed conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants