-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented resolving AssemblyMetadata, build configuration format strings and build error on dirty repo #14
base: master
Are you sure you want to change the base?
Conversation
…ps build time constant until Visual Studio Solution is reloaded)
…sep>:<ref>} added
…itory contains modified (dirty)
…nsensitive Regex match for <ref>
…o avoid error message "Revision ID cannot be truncated to dotted-numeric"
Hello Ives, I added another patch to avoid the error message "Revision ID cannot be truncated to dotted-numeric" when the repository was empty and did not yet receive a tag. I can't tell if the solution I have chosen with 56485af is the way to go, but it works for the issue I currently had. Best regards, |
Just wanted to give a quick feedback. I'm very busy with other time-critical projects at the moment but these changes sound interesting and I'll take a look at them. Please don't be too sad if I won't make it anymore this year. |
Thanks for your feedback, Yves. I made a local build and can work with it for now. Take your time. |
Merged latest changes and fixed conflicts. |
Hello Yves,
I have extended Net Revision Task with the following changes:
AssemblyMetadata
attributes value format strings (enabled by default)GetVersion()
is called (otherwise the build time stays constant until the Solution is reloaded){bconf}
,{BCONF}
and{bconf:<sep>:<ref>}
format strings to resolve build configuration namesPlease let me know if you don't agree with the changes or see potential for optimizations.
Best regards,
Mark