Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies in parallel builds #48

Open
chusopr opened this issue Jul 9, 2020 · 3 comments
Open

Missing dependencies in parallel builds #48

chusopr opened this issue Jul 9, 2020 · 3 comments

Comments

@chusopr
Copy link
Contributor

chusopr commented Jul 9, 2020

Hi,

I've found very often that builds fail when more than one make job is run in parallel with errors that seem to be related to trying to pull dependencies that are not built yet:

File "src/networks/donkey/donkeyNodesDat.ml", line 3, characters 5-18:
3 | open CommonOptions
         ^^^^^^^^^^^^^
Error: Unbound module CommonOptions

Other times I get an error about missing Printf2, but I was not able to reproduce it for this ticket.

Those errors disappear when telling make to use only one job (-j1).

I don't know enough about OCaml or Make to debug it, but it seems to miss something to enforce dependencies are built first.

@ygrek
Copy link
Owner

ygrek commented Jul 17, 2020

This is unlikely I will work on this one.
More likely is that I will try to get rid of make build system in favor of dune, but no ETA.

@chusopr
Copy link
Contributor Author

chusopr commented Jul 18, 2020

Yes, I get it, especially when there is a workaround. And I think the current system is a bit outdated too.
But I thought it was appropriate to report it and also that way people with the same issue could find the workaround.

@ygrek
Copy link
Owner

ygrek commented Jul 18, 2020

Yes, sure, thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants