Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc 11 /CryptoPP.{cc,h} breakage, and workaround with CXXFLAGS=-std=c++14 #62

Closed
HinTak opened this issue May 6, 2021 · 3 comments
Closed

Comments

@HinTak
Copy link
Contributor

HinTak commented May 6, 2021

gcc 11 defaults to c++17, which introduces std::byte, which causes a lot of breakage when compiling src/utils/lib/CryptoPP.hsrc/utils/lib/CryptoPP.{cc,h} .

Apparently the problem has been anticipated upstream,
https://cryptopp.com/wiki/Std::byte , and somewhat address with cryptopp 6.x . (while mldonkey has 5. x according to the header). For the time being, doing CXXFLAGS=-std=c++14 works; but it is probably best upgrading...

@HinTak
Copy link
Contributor Author

HinTak commented May 6, 2021

Since it already checks g++ version and try a few flags

ACX_CHECK_CXX_FLAGS(-fno-omit-frame-pointer,cv_no_omit_frame_pointer, CRYPTOPPFLAGS="-fno-omit-frame-pointer")
, it may be a good idea to include ...std=c++14 in any case?

@HinTak HinTak closed this as completed May 6, 2021
@HinTak HinTak reopened this May 6, 2021
@HinTak
Copy link
Contributor Author

HinTak commented May 6, 2021

Pull in #63 as outlined

@HinTak
Copy link
Contributor Author

HinTak commented Jul 4, 2021

#63 merged. Can close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant