theme_gray inconsistencies with ggplot2

[funnell]

• minor gridlines
• grey borders when there should be none
• outward facing major tick marks on left and bottom borders

The way themes are handled might need to be changed to allow theming of some plot elements that aren't adjustable through rc params.

[glamp]

Do you know how to fix it? If so, can you submit a PR?

On Wed, Oct 30, 2013 at 2:47 PM, Tyler Funnell notifications@github.comwrote:

• minor gridlines
• grey borders when there should be none
• outward facing major tick marks on left and bottom borders

The way themes are handled might need to be changed to allow theming of
some plot elements that aren't adjustable through rc params.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/85
.

[funnell]

I can start something but I'm worried it might conflict with the work in #75

[jankatins]

Here are probably some hints how to implement that in rcparams: https://github.com/mwaskom/seaborn/blob/master/seaborn/rcmod.py

[jankatins]

Also here: https://github.com/wrobstory/climatic/blob/master/climatic/stylers.py

    #Only show bottom left ticks, pointing out of axis
    plt.rcParams['xtick.direction'] = 'out'
    plt.rcParams['ytick.direction'] = 'out'
    ax.xaxis.set_ticks_position('bottom')
    ax.yaxis.set_ticks_position('left')

If the last two methods are not available via rcParams, one way to implement this, would be to add a possibility for the themes to submit a callback which would then be called for each axis (see also #93)

[funnell]

As far as I'm aware at least some of the styling options are not available via rcParams. I think a callback might be the best way to go about this.

[jankatins]

I added a commit to my theming branch, which implementes post_plot_callbacks: #75 -> last commit "Implement post plot callback for theming".

[jankatins]

Whats currently missing is minor gridlines.

[funnell]

The last link you provided implements minor gridlines this way:

ax.xaxis.set_minor_locator(MultipleLocator( (plt.xticks()[0][1]-plt.xticks()[0][0]) / 2.0 ))
ax.yaxis.set_minor_locator(MultipleLocator( (plt.yticks()[0][1]-plt.yticks()[0][0]) / 2.0 ))