-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial steps to python3 compatabilityPython3 compatability... #21
Conversation
Made the necessary edits to get the example.py file to run on: Python 3.3.2 matplotlib 1.3.1 pandas 0.12.0 Clearly more testing is required, but at least now the example file runs :) Ammended: fixed bug where example data wouldnt load if run from different folder than ggplot/ggplot
<<<<<<< HEAD | ||
import os | ||
======= | ||
>>>>>>> d212a5a4e7fa75dd468ea2f284609595f51e702e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, you accidentally left some git merge junk in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, crap, so I have. Let me fix that - kind of new to git :)
Hello, I'm deeply impressed by ggplot and your py3 branch.
at this one example below (under python3.3, ipython 1.0, matplotlib 1.3.0, via winpython3.3.2.3)
it seems it loop inside itself in matplotlib\dates.py.
|
@@ -4,13 +4,13 @@ | |||
from datetime import timedelta | |||
import numpy as np | |||
from copy import deepcopy | |||
from geom import geom | |||
from .geom import geom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this work in 2.7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runs on my 2.7.5 installation, haven't had a chance to test with earlier versions.
Relevant SO entry: http://stackoverflow.com/questions/12172791/changes-in-import-statement-python3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool looks good
continuation of the action yhat#21
continuation of the action yhat#21
Made the necessary edits to get the example.py file to run on:
Python 3.3.2
matplotlib 1.3.1
pandas 0.12.0
Clearly more testing is required, but at least now the example file runs :)