Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of legend
As shown in #304 and #89 the current legend is drawn once per aesthetic (outside of x and y). This behaviour creates duplicate information when we use for example color and fill along the
same variable.
I've reworked the legend to group information per variable and display for example one line showing both shape, color and alpha information. The reworked legend also address: #273.
New Features
Things that don't work
Changes
components/colors.py
,components/alphas.py
,components/sizes.py
etc) as it's currently done. To do so I've added a function calledget_labels
tocomponents/legend.py
and call it from the respective files. I think this counts as a work around and potentially a refactoring of the codebase would eliminate the need for aget_labels
function, but currently I don't see any other obvious way of doing it.Examples