Allow links in the inside of code and pre element #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
commented
May 8, 2019
test/html.tsx
Outdated
| expect(html(<code>{'<#C01234567>'}</code>)).toBe('`<#C01234567>`') | ||
|
|
||
| // Work escape correctly | ||
| expect(html(<code><!channel></code>)).toBe('`<!channel>`') |
There was a problem hiding this comment.
It seems to return same result as <code>{'<!channel>'}</code>. jsx-slack could not detect whether using escaped entity like < and >. This test case is still valid in using entities via JSX interpolation, like <code>{'<!channel>'}</code>.
|
A base improvement #33 for this change was merged. This PR is too outdated, so I'll continue to work in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now,
<a>tag in the inside of<code>and<pre>won't recognize as link. It is the correct behavior in regular Markdown's backtick(s), but not in Slack mrkdwn format and regular HTML. It allows link format<xxx|xxx>in the inside of inline code and fence.For consistent HTML element support, we would require to change behavior as these:
<code>and<pre>allow<a>tag and<time>tag.`Hello, <https://www.example.com/|example>.`(Requires JSX string interpolation)<and>via interpolation explicitly to escape link format.