Added conversion of percent height to LaTex unit. #1482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
requested changes
Dec 30, 2017
R/utils.R
Outdated
| @@ -355,6 +356,17 @@ percent_latex_width = function(x) { | |||
| x | |||
| } | |||
|
|
|||
| # turn percent height to LaTeX unit, e.g. out.height = 30% -> .3\textheight | |||
| percent_latex_height = function(x) { | |||
There was a problem hiding this comment.
Apparently the code in this function pretty much duplicates percent_latex_width(). Can you try to merge the two into one and use an argument to control whether it is for width or height?
There was a problem hiding this comment.
Changes merging the two into one committed.
|
Sorry for closing this PR. Normally I wouldn't do it, but this time the fix is simple enough, and I feel we probably need two more rounds of revisions in this PR, so I went ahead and did it by myself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch,
out.heightfor figures when specified as a percent leads to the percent sign get passed into pandoc causing parsing problems. The patch translates the percent to the equivalent fraction of\textheightFixes rstudio/bookdown#501