Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Image Ids #1979

Closed
wants to merge 25 commits into from
Closed

Allow for Image Ids #1979

wants to merge 25 commits into from

Conversation

muschellij2
Copy link
Contributor

This is an old PR that was killed about 1.5 years ago. Here is the branch I had to fix #1752. I'm not sure it sill is going to fix rstudio/bookdown#766 and it definitely needs to be squashed, but this is what I could do on a short turnaround @cderv

@cderv
Copy link
Collaborator

cderv commented Mar 30, 2021

Thanks!

@muschellij2
Copy link
Contributor Author

Not sure about the knitr_examples failure.

@cderv
Copy link
Collaborator

cderv commented Mar 30, 2021

Don't worry, we'll look into it.

@cderv
Copy link
Collaborator

cderv commented May 4, 2023

This has been added a bit differently in #2169 so I'll close this.

We will see how we can leverage the new fig.id option to fix bookdown issue maybe.

Thanks again

@cderv cderv closed this May 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in epub and epubcheck
2 participants