Add fig.asp = NULL as default in opts_chunks

[cderv]

option was added a while back in 464d4d0

Related to quarto-dev/quarto-cli#5670 by @mcanouil as Quarto should have probably known about this option from opts_chunk

@yihui any reason not to add it ?

Thanks!

[yihui]

Yes, the reason not to add it into opts_chunk is that it will invalidate existing cache, because cache depends on chunk options. This is one thing that I regret very much in knitr since it makes it hard to add new chunk options into opts_chunk.

RStudio uses opts_chunk_attr to recognize chunk options, e.g.,

knitr/R/defaults.R

Line 123 in 8403ca5

opts$fig.asp = 'numeric'

but even opts_chunk_attr doesn't contain all available chunk options. Changing this object is risk-free, though.

[cderv]

Yes, the reason not to add it into opts_chunk is that it will invalidate existing cache, because cache depends on chunk options. This is one thing that I regret very much in knitr since it makes it hard to add new chunk options into opts_chunk.

@mcanouil I knew there was a reason not every option was in opts_chunk ! I couldn't remember why exactly.

The initial trigger of this is that Quarto uses names(knitr::opts_chunk$get()) to know which options are knitr options. And then add others manually.

We could probably do the same as RStudio IDE object but for Quarto, or use the same by providing all options into opts_chunk_attr and use this