Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default order. #17

Merged
merged 6 commits into from
May 16, 2023
Merged

Fix default order. #17

merged 6 commits into from
May 16, 2023

Conversation

terabytesoftw
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #17 (a8031e5) into main (c4140be) will decrease coverage by 0.56%.
The diff coverage is 96.15%.

❗ Current head a8031e5 differs from pull request most recent head 886d11a. Consider uploading reports for the commit 886d11a to get more accurate results

@@              Coverage Diff              @@
##                main      #17      +/-   ##
=============================================
- Coverage     100.00%   99.44%   -0.56%     
- Complexity        72       78       +6     
=============================================
  Files              6        6              
  Lines            167      180      +13     
=============================================
+ Hits             167      179      +12     
- Misses             0        1       +1     
Impacted Files Coverage Δ
src/Sort.php 99.08% <94.44%> (-0.92%) ⬇️
src/ActiveIteratorDataProvider.php 100.00% <100.00%> (ø)
src/ArrayIteratorDataProvider.php 100.00% <100.00%> (ø)
src/QueryIteratorDataProvider.php 100.00% <100.00%> (ø)
src/SQLIteratorDataDataProvider.php 100.00% <100.00%> (ø)

@terabytesoftw terabytesoftw merged commit 72f702e into main May 16, 2023
@terabytesoftw terabytesoftw deleted the fix-default-order branch May 16, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants