Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhacements. #3

Merged
merged 11 commits into from Jun 5, 2020
Merged

Enhacements. #3

merged 11 commits into from Jun 5, 2020

Conversation

terabytesoftw
Copy link
Member

@terabytesoftw terabytesoftw commented Jun 4, 2020 •
edited by viktorprogger
Loading

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Tests pass? ✔️
  • Fix coverage scrutinizer github/actions.
  • Add standard key providers vendor-name/package-name/provider.
  • Add prefix FileRotator property in ApplicationsParameters.
  • Add SessionProvider.
  • Update README.md.
  • More clean up code.

@terabytesoftw terabytesoftw requested review from samdark and a team June 4, 2020 01:00
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Jun 4, 2020
samdark
samdark requested changes Jun 4, 2020
View reviewed changes
.github/workflows/build.yml Show resolved Hide resolved
config/common.php Outdated Show resolved Hide resolved
config/providers.php Outdated Show resolved Hide resolved
config/providers.php Outdated Show resolved Hide resolved
config/web.php Outdated Show resolved Hide resolved
@samdark samdark added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Jun 4, 2020
@terabytesoftw terabytesoftw added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Jun 4, 2020
samdark
samdark reviewed Jun 4, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/ApplicationParameters.php Show resolved Hide resolved
samdark
samdark reviewed Jun 4, 2020
View reviewed changes
config/providers.php Show resolved Hide resolved
config/providers.php Outdated Show resolved Hide resolved
@samdark samdark merged commit 0314383 into yiisoft:master Jun 5, 2020
@samdark
Copy link
Member

samdark commented Jun 5, 2020

👍

@terabytesoftw terabytesoftw deleted the Enhacements branch June 22, 2020 12:44
@wiperawa wiperawa mentioned this pull request Jul 3, 2020
Closed
@fufudao fufudao mentioned this pull request Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terabytesoftw @samdark