Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhacements #81

Merged
merged 19 commits into from
Oct 29, 2020
Merged

Enhacements #81

merged 19 commits into from
Oct 29, 2020

Conversation

terabytesoftw
Copy link
Member

@terabytesoftw terabytesoftw commented Oct 27, 2020

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
  • Remove all providers.
  • Remove npm if you like the solution it should be applied in yii-bulma and boostrap using asset-packagist.org and oomphinc/composer-installers-extender -> Proposal remove npm dependency yii-bulma#11
  • Apply new config.

Note:

The template does not have code-coverage because they deleted the c3.php from index.php, you can add it again just say it.

@terabytesoftw terabytesoftw requested review from samdark and a team October 27, 2020 16:52
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Oct 27, 2020
@samdark
Copy link
Member

samdark commented Oct 29, 2020

Yeah, please re-add it. Codeception/c3#62 could be related.

composer.json Show resolved Hide resolved
config/common/applicacion-parameters.php Outdated Show resolved Hide resolved
@terabytesoftw terabytesoftw requested review from samdark and a team October 29, 2020 12:46
@samdark samdark merged commit 9956a68 into yiisoft:master Oct 29, 2020
@samdark
Copy link
Member

samdark commented Oct 29, 2020

Awesome. This makes configs better 👍

@samdark
Copy link
Member

samdark commented Oct 29, 2020

@terabytesoftw would you please apply similar approach to yii-demo?

@terabytesoftw terabytesoftw deleted the enhacements branch October 29, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move providers out of the app where possible Remove SubFolder middleware from pipeline
5 participants