Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify recursion depth for recursive modifier #155

Merged
merged 6 commits into from
Dec 7, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Dec 6, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

Fix #154

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c41c37f) 99.58% compared to head (3da856e) 99.59%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #155      +/-   ##
============================================
+ Coverage     99.58%   99.59%   +0.01%     
- Complexity      277      282       +5     
============================================
  Files            22       22              
  Lines           718      736      +18     
============================================
+ Hits            715      733      +18     
  Misses            3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Dec 6, 2023

PR Summary

  • Enhancement of Recursion Depth Feature
    The Pull Request has included an improvement that now allows users to specify how deep they want the system to go into a thread or task while repeating a function (this process is known as "recursion"). This ability has been added to the update log (CHANGELOG.md).

  • Code Examples for New Feature
    Practical coding examples highlighting how to utilize our newly introduced feature have been added to the instruction manual (README.md).

  • Minor Code Optimizations
    Minor code adjustments have been made to enhance the stability of the programme. This includes ignoring irrelevant issues identified by our code checker 'Psalm' in psalm.xml, and adjustments made in DataModifiers.php and Merger.php files.

  • Improved Construct
    An updated constructor parameter and getter method for managing "recursion depth" levels have been added to RecursiveMerge.php.

  • Ensuring Robustness
    A thorough set of tests has been conducted and encoded in ConfigTest.php for different levels of recursion depths to ensure the new feature works across various conditions.

  • Test Cases Included
    Additional files that include the specific test cases used for checking the newly added feature can be found in the /tests/TestAsset/configs/recursion-depth directory.

@vjik vjik requested a review from a team December 6, 2023 10:25
@vjik vjik added the status:code review The pull request needs review. label Dec 6, 2023
README.md Outdated Show resolved Hide resolved
src/DataModifiers.php Show resolved Hide resolved
src/DataModifiers.php Show resolved Hide resolved
src/DataModifiers.php Outdated Show resolved Hide resolved
vjik and others added 4 commits December 7, 2023 11:27
Co-authored-by: Alexey Rogachev <arogachev90@gmail.com>
Co-authored-by: Alexey Rogachev <arogachev90@gmail.com>
@vjik vjik merged commit f8288d9 into master Dec 7, 2023
31 of 34 checks passed
@vjik vjik deleted the recursive-depth branch December 7, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional parameter "depth" to recursive modifier
3 participants