Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config merger #163

Merged
merged 15 commits into from
Dec 25, 2023
Merged

Fix config merger #163

merged 15 commits into from
Dec 25, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Dec 25, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Fix #153

Copy link

what-the-diff bot commented Dec 25, 2023

PR Summary

  • Added new feature to handle duplication exceptions
    The change log has been updated to include a specific exception handling for situations involving 'Duplicate key' when using nested groups. This addition will effectively manage any duplication errors and improve overall functionality.

  • Enhancement in Config.php
    Two new methods - shelve() and unshelve() have been added to Config.php. These methods, particularly useful for managing temporary storage spaces.

  • Update in Merger.php
    A new storage property ($shelveStorage) has been added in the Merger.php file along with the same shelve() and unshelve() methods, further streamlining data management processes.

  • New integrative tests and schemas
    To ensure that everything works perfectly, we've introduced a new test file (NestedGroupBug153Test.php) and setup files (di.php and di-web.php) in the tests/Integration/NestedGroupBug153 folder.

  • Package management improvements
    A new composer.json file has been added in the tests/Integration/NestedGroupBug153/packages/a folder. With this, we now have better management and understanding of the project's dependencies.

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ef9884) 100.00% compared to head (d457d2d) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #163   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       277       277           
===========================================
  Files             22        22           
  Lines            728       725    -3     
===========================================
- Hits             728       725    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team December 25, 2023 07:32
@vjik vjik added status:code review The pull request needs review. status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Dec 25, 2023
@vjik vjik added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Dec 25, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
vjik and others added 4 commits December 25, 2023 13:06
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
@vjik vjik added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Dec 25, 2023
@vjik vjik added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Dec 25, 2023
@vjik vjik merged commit f6c3d85 into master Dec 25, 2023
23 of 24 checks passed
@vjik vjik deleted the fix-merger branch December 25, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw duplicate error on use nested groups
4 participants