Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Сode cleanup #87

Merged
merged 6 commits into from
Oct 22, 2021
Merged

Сode cleanup #87

merged 6 commits into from
Oct 22, 2021

Conversation

devanych
Copy link
Member

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixed issues -

⚠️ This is PR for #81

@devanych devanych requested a review from vjik October 22, 2021 19:34
@devanych devanych added the status:code review The pull request needs review. label Oct 22, 2021
vjik
vjik reviewed Oct 22, 2021
View reviewed changes
src/FilesExtractor.php Outdated Show resolved Hide resolved
vjik
vjik reviewed Oct 22, 2021
View reviewed changes
src/Merger.php Outdated Show resolved Hide resolved
vjik
vjik reviewed Oct 22, 2021
View reviewed changes
src/FilesExtractor.php Outdated Show resolved Hide resolved
@devanych devanych requested a review from vjik October 22, 2021 20:16
@devanych devanych merged commit 0a2f003 into alternative-implementation Oct 22, 2021
@devanych devanych deleted the code-cleanup branch October 22, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik Awaiting requested review from vjik

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devanych @vjik