Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt for last changes #37

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

Gerych1984
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?
  1. Change input type for createItem to array|object
  2. Allow readOne and getIterator to createItem
  3. Change access getHandlerByOperation to public. It can be useful for some cases like
$arQuery->with([
       'relation' => function($query) use ($dataReader, $filter) { 
               $handler = $dataReader->getHandlerByOperation($filter);
               $handler->applyFilter($query, $filter);
       }
])

Copy link

what-the-diff bot commented Nov 23, 2023

PR Summary

  • Enhancement of 'AbstractQueryDataReader.php'
    Introduced changes in several methods and included the use of newly added functions, which will augment the performance and functionality of this file. It's now better prepared to handle different types of input and ensures smoother data handling.

  • Update 'QueryDataReader.php'
    Enhanced the method createItem to now accept both array and object data types as a parameter. This means the change gives our data reader greater flexibility in the type of data it can process.

  • Additions in 'DataReaderTest.php'
    A new test case is added for the createItem method, which is a function in CustomerDataReader. This strengthens our testing suite and ensures the enhanced createItem method functions as expected.

  • New Files in 'tests/Support'
    Added two new files CustomerDTO.php and CustomerDataReader.php. These files help in effective data testing by simulating customer data, thus improving the robustness of our tests.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3496ff7) 62.31% compared to head (8b648cf) 69.78%.

Files Patch % Lines
src/AbstractQueryDataReader.php 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
+ Coverage     62.31%   69.78%   +7.46%     
- Complexity      169      171       +2     
============================================
  Files            44       44              
  Lines           414      417       +3     
============================================
+ Hits            258      291      +33     
+ Misses          156      126      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gerych1984 Gerych1984 force-pushed the adopt-last-changes branch 3 times, most recently from 001b20a to 15addeb Compare November 23, 2023 11:19
@samdark samdark merged commit 9b6e2e3 into yiisoft:master Nov 23, 2023
14 of 17 checks passed
@samdark
Copy link
Member

samdark commented Nov 23, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants