Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not preserve keys of filtered items in iterable data reader #182

Closed
arogachev opened this issue May 16, 2024 · 2 comments
Closed

Do not preserve keys of filtered items in iterable data reader #182

arogachev opened this issue May 16, 2024 · 2 comments
Assignees
@samdark
Labels
type:docs Documentation

Comments

@arogachev
Copy link
Contributor

No description provided.

@vjik
Copy link
Member

vjik commented May 17, 2024

Suggest don't change iterable data reader, but add comment to ReadableDataInterface::read() about keys (keys can have any value, you should not rely on them somehow).

@samdark
Copy link
Member

samdark commented May 22, 2024

Agree.

@samdark samdark self-assigned this Sep 7, 2024
@samdark samdark added type:docs Documentation and removed type:bug Bug labels Sep 7, 2024
samdark added a commit that referenced this issue Sep 7, 2024
@samdark
Fix #182: Add note about keys
239d406
@samdark samdark closed this as completed in d77f8ff Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samdark samdark

Labels
type:docs Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samdark @vjik @arogachev