Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Handler suffix to filter handlers #131

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

samdark
Copy link
Member

@samdark samdark commented Jan 11, 2023

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues #128

@samdark samdark requested a review from vjik January 11, 2023 06:43
@what-the-diff
Copy link

what-the-diff bot commented Jan 11, 2023

  • Rename all classes in src/Reader/Iterable/FilterHandler to end with Handler
  • Update tests accordingly
  • Rename AllTest.php to AllHandlerTest.php
  • Replace all occurrences of "All" with "AllHandler".
  • Replace all occurrences of Equals, GreaterThanOrEqual and LessThanOrEqual with their Handler counterparts (EqualsHandler etc).
  • Rename classes to follow PSR-4 standard.
  • Fix tests for renamed classes and methods.
  • Rename LessThan to LessThanHandler
  • Rename Like to LikeHandler
  • Remove unused import in NotTest class (Equals) and replace it with EqualsHandler

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 99.35% // Head: 99.35% // No change to project coverage 👍

Coverage data is based on head (dcab51f) compared to base (cc7bc93).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #131   +/-   ##
=========================================
  Coverage     99.35%   99.35%           
  Complexity      252      252           
=========================================
  Files            35       35           
  Lines           620      620           
=========================================
  Hits            616      616           
  Misses            4        4           
Impacted Files Coverage Δ
src/Reader/Iterable/FilterHandler/AllHandler.php 100.00% <ø> (ø)
src/Reader/Iterable/FilterHandler/AnyHandler.php 100.00% <ø> (ø)
...c/Reader/Iterable/FilterHandler/BetweenHandler.php 100.00% <ø> (ø)
...c/Reader/Iterable/FilterHandler/CompareHandler.php 100.00% <ø> (ø)
...ader/Iterable/FilterHandler/EqualsEmptyHandler.php 100.00% <ø> (ø)
...rc/Reader/Iterable/FilterHandler/EqualsHandler.php 100.00% <ø> (ø)
...eader/Iterable/FilterHandler/EqualsNullHandler.php 100.00% <ø> (ø)
...ader/Iterable/FilterHandler/GreaterThanHandler.php 100.00% <ø> (ø)
...erable/FilterHandler/GreaterThanOrEqualHandler.php 100.00% <ø> (ø)
src/Reader/Iterable/FilterHandler/GroupHandler.php 100.00% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik merged commit 273064b into master Jan 11, 2023
@vjik vjik deleted the 128-add-handler-suffix branch January 11, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants