Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch insert with empty columns #251

Merged
merged 8 commits into from
Jan 9, 2024
Merged

Batch insert with empty columns #251

merged 8 commits into from
Jan 9, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 3, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Jan 3, 2024

PR Summary

  • Addition of New Columns to 'type' Table
    Two new columns were added to the 'type' table. First is float_col, which will hold numbers with decimals, providing high precision. Second is char_col, which holds character strings up to 100 characters long.
  • Introduction of 'blob_col' with Default Value
    An additional column blob_col was introduced to the 'type' table. This type of column is often used to store large amount of binary data like images or files. By default, if no value is provided, this column will be empty (NULL).
  • Removal of Certain Columns from 'type' Table
    Two previously existing columns, char_col and blob_col, were removed from the 'type' table. This removal likely reflects a change in the data structure requirements for this table.

@Tigrov Tigrov changed the title Update fixtures according to tests Batch insert with empty columns Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b28ffb) 98.23% compared to head (0793d12) 98.18%.

❗ Current head 0793d12 differs from pull request most recent head 15497bb. Consider uploading reports for the commit 15497bb to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #251      +/-   ##
============================================
- Coverage     98.23%   98.18%   -0.06%     
+ Complexity      177      173       -4     
============================================
  Files            16       16              
  Lines           568      552      -16     
============================================
- Hits            558      542      -16     
  Misses           10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need line in changelog

@Tigrov Tigrov requested a review from vjik January 8, 2024 11:22
@Tigrov Tigrov merged commit 704f56c into master Jan 9, 2024
2 of 3 checks passed
@Tigrov Tigrov deleted the batchInsert-empty-columns branch January 9, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants